Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misclicks on drop down panels cause selection to be lost #5358

Closed
Reinmar opened this issue May 10, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-ui#235
Closed

Misclicks on drop down panels cause selection to be lost #5358

Reinmar opened this issue May 10, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-ui#235
Assignees
@oleq
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented May 10, 2017

We had a ticket for it, but I can't find it at the moment. I can really often reproduce this issue:

may-10-2017 15-22-57

I think it's related to the issue we had in the past that when there's any dragstart+move sequence the selection is being lost. This is very important issue when you try to actually use the editor for real.
@Reinmar
Copy link
Member Author

Reinmar commented May 17, 2017

DUP: #440.

@Reinmar Reinmar closed this as completed May 17, 2017
@Reinmar
Copy link
Member Author

Reinmar commented May 17, 2017

And I misclicked "close" :D

@Reinmar Reinmar reopened this May 17, 2017
@oleq
Copy link
Member

oleq commented May 17, 2017

I guess it could be a matter of blocking the drag and drop in the dropdown.

@oleq oleq self-assigned this May 18, 2017
oleq referenced this issue in ckeditor/ckeditor5-ui May 19, 2017
@oleq
Fix: Clicking and dragging in a dropdown panel should not break the s…
9d88909 
…election. Closes #228.
oleq referenced this issue in ckeditor/ckeditor5-ui May 29, 2017
@oleq
Tests: Added a manual test for #228.
3dd7013
oleq referenced this issue in ckeditor/ckeditor5-ui May 29, 2017
@oleq
Docs: Made #228 docs more verbose.
1fc212c
Reinmar referenced this issue in ckeditor/ckeditor5-ui May 29, 2017
@Reinmar
Merge pull request #235 from ckeditor/t/228
6066a09 
Fix: Clicking and dragging in a drop-down panel should not break the selection. Closes #228.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
3 participants
@Reinmar @oleq @mlewand