Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContextualBalloon should use keepAttachedTo instead of attachTo #5336

Closed
oskarwrobel opened this issue Apr 7, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#196
Closed

ContextualBalloon should use keepAttachedTo instead of attachTo #5336

oskarwrobel opened this issue Apr 7, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#196
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 10

Comments

@oskarwrobel
Copy link
Contributor

Balloon should stick to the target element on scroll and resize.
oleq referenced this issue in ckeditor/ckeditor5-ui Apr 12, 2017
@oleq
Merge pull request #196 from ckeditor/t/192
28dd457 
Fix: ContextualBalloon plugin should use BalloonPanelView#pin instead of #attachTo. Closes #192.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 10 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 9, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 10
Development

Successfully merging a pull request may close this issue.

Used pin instead of attachTo for ContextualBalloon. ckeditor/ckeditor5-ui
2 participants
@oskarwrobel @mlewand