Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing long text with composable input has a visible delay #3114

Closed
f1ames opened this issue Apr 11, 2018 · 7 comments
Closed

Replacing long text with composable input has a visible delay #3114

f1ames opened this issue Apr 11, 2018 · 7 comments
Labels
package:typing resolution:expired This issue was closed due to lack of feedback. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@f1ames
Copy link
Contributor

f1ames commented Apr 11, 2018

Found while working on https://github.com/ckeditor/ckeditor5-engine/issues/403.

While diff in mutations is used only for simple mutations (inserting single character on collapsed or non-collapsed selection) it works fine for regular typing, but when character is composable one (e.g. Spanish accent or Hiragana typing) the diff function used in mutations slows down significantly:

diff3

@Reinmar
Copy link
Member

Reinmar commented Apr 11, 2018

Cool. Good to know that we can improve this if we'll introduce a fast diff.

@f1ames
Copy link
Contributor Author

f1ames commented Apr 17, 2018

Yes, we should check if fastDiff (when merged to master) can be used here (in mutations handler) and if it can improve this situation.

@Reinmar
Copy link
Member

Reinmar commented May 24, 2018

Still todo?

@f1ames
Copy link
Contributor Author

f1ames commented May 25, 2018

Yes, since fastDiff was already merged we may start working on this one. It will require switching from diff to fastDiff in mutations handler.

The only difference is that diff is more accurate. It finds (well, in theory at least) minimal number of changes, while fastDiff is basically a partial diff so number of insertions and deletions will usually be higher. Still it shouldn't be a problem here (we should check if it will has some effect on undo steps).

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:typing labels Oct 9, 2019
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added resolution:expired This issue was closed due to lack of feedback. and removed status:stale labels Jan 15, 2024
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:typing resolution:expired This issue was closed due to lack of feedback. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

5 participants