-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference issues while installing ckeditor5 plugins in React #62
Comments
Could you prepare a minimal sample that allows reproducing the issue? I mean |
@pomek Just updated my comment with package.json and my component. |
Your Webpack configuration requires additional files like |
@pomek My Webpack config has
|
Yes, I know. What I wanted to say: I don't have those files and Node will throw an error that it can't resolve the paths (missing files). |
Should I push my whole code on GitHub and maybe after that you can take a look at that? I just created that using |
After disabling Why do we have css files inside the cc: @ma2ciek |
That is working in my system too. But I want Comments feature as major, that's why I am using CKEditor. Lol. |
Yea, I know. I am just sharing my debug notes here because I am not going to be a one person that will trying to help you :D |
@pomek So as far I have debugged it, the css files are dependent on each other like unselectable.css, users.css, sidebar.css. But these are situated at different locations with different folder structure. Instead of putting all these CSS files in different locations/packages. Why not put every stylesheet in This will reduce the code dependency. Just saying. |
@reeversedev, just to be sure, because you've been pingning me on Twitter – the comments feature is a paid addon so I assume you contacted us and you're using a trial now. However, in this case you can contact our official support channel instead of me :). Anyway, we're looking into this issue and let you know what's the solution. |
@reeversedev, Webpack configuration does not handle CSS files which are inside After modifying CSS Loader for CKEditor 5 assets: {
test: [
/ckeditor5-[^/\\]+[/\\]theme[/\\].+\.css/,
/ckeditor5-[^/\\]+[/\\]src[/\\].+\.css/ // <--- added this one and replaced "test" with an array
// ^ the same path should be excluded in "file-loade" at the end of "oneOf" section in the config file
],
use: [
{
loader: 'style-loader',
options: {
singleton: true
}
},
{
loader: 'postcss-loader',
options: styles.getPostCssConfig({
themeImporter: {
themePath: require.resolve('@ckeditor/ckeditor5-theme-lark')
},
minify: true
})
}
]
}, The editor is being built and throws other error:
But this error is not a part of your issue with Webpack configuration. |
In our documentation you can find an article about Integrating comments with your application. It should help you. |
I've been trying to implement comments only feature and been getting a lot of problems.
This is the error i am getting:
Module not found: Can't resolve './@ckeditor/ckeditor5-collaboration-core/src/users/users.css'
My Webpack Config
Package.json
App.js
Please let me know If i am doing something wrong here.
The text was updated successfully, but these errors were encountered: