Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a keystroke to display the toolbar in a collapsed selection #2344

Closed
oleq opened this issue May 31, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-editor-balloon#8
Closed

Implement a keystroke to display the toolbar in a collapsed selection #2344

oleq opened this issue May 31, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-editor-balloon#8
Assignees
@oleq
Labels
domain:accessibility This issue reports an accessibility problem. package:editor-balloon type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 11

Comments

@oleq
Copy link
Member

oleq commented May 31, 2017

It would certainly:

  1. Help our users change the block type without making the actual selection.
  2. Improve the accessibility of the application.

A follow-up of ckeditor/ckeditor5-editor-balloon#1.
@oleq
Copy link
Member Author

oleq commented Jun 20, 2017

I'm wondering if Alt+F10 is the right keystroke to show and focus the toolbar in such situation. Or maybe a new keystroke is needed?

@Reinmar
Copy link
Member

Reinmar commented Jun 20, 2017

For me it could be the good old Alt+F10.

@oleq oleq self-assigned this Jul 3, 2017
@oleq
Copy link
Member Author

oleq commented Jul 3, 2017

The implementation in https://github.com/ckeditor/ckeditor5-editor-balloon-toolbar/tree/t/3, awaiting https://github.com/ckeditor/ckeditor5-ui/issues/263 to close.

Reinmar referenced this issue in ckeditor/ckeditor5-editor-balloon Jul 20, 2017
@Reinmar
Merge pull request #8 from ckeditor/t/3
c745e05 
Other: Implemented a keystroke to display the toolbar in a collapsed selection. Closes #3.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-editor-balloon Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:editor-balloon labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
@Reinmar Reinmar added the domain:accessibility This issue reports an accessibility problem. label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
domain:accessibility This issue reports an accessibility problem. package:editor-balloon type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 11
3 participants
@Reinmar @oleq @mlewand