Adjust easy image to CS token refreshing mechanism #2558
Assignees
Labels
package:easy-image
type:task
This issue reports a chore (non-production change) and other types of "todos".
Milestone
Comments
pjasiun
referenced
this issue
in ckeditor/ckeditor5-easy-image
Oct 31, 2017
Other: Aligned code to the new CloudeServices API and use `ckeditor5-cloudservices` package. Closes #7. Feature: The plugin will now automatically refresh token when it will expire. BREAKING CHANGE: Easy Image plugin do not use `cloudeservices.token` config anymore. The proper config now is `cloudeservices.tokenUrl`with the URL to the token server.
mlewand
added
status:confirmed
type:task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After this ticket will be closed: https://github.com/ckeditor/ckeditor-cloudservices-core/issues/4 CS will automatically request and update token. That's really cool.
But it means that easy image configuration will have to change. Instead of the token, one will set the URL and the
Tokenclass will automatically request for the token.However, it also means that we need to have a plugin which takes the configuration, create a token class and provide it to all plugins which connect with CS. Otherwise, each plugin will create its own request to refresh the token what will be wrong.
Also, such plugin should not be part of the
easy-imagerepository, because it would be strange that all plugins requireckeditor5-easy-image. So we need ackeditor5-cloudeservicesrepository.In fact, it will be nice because of one more reason: it will fit the convention that the name of the configuration is the name of the plugin which reads this configuration. Now,
easy-imageis usingcloudeServices.tokenconfig. After the changecloudeServices.tokenUrlwill be the configuration of thecloudeServicesplugin.The text was updated successfully, but these errors were encountered: