Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rgbpp-sdk/ckb): Increase the max length of rgbpp inputs to 40 #179

Merged
merged 2 commits into from
May 21, 2024
Merged

feat(rgbpp-sdk/ckb): Increase the max length of rgbpp inputs to 40 #179

merged 2 commits into from
May 21, 2024

Conversation

duanyytop
Copy link
Collaborator

Main Changes

  • Increase the max length of RGB++ inputs to 40 to make sure the CKB TX with many inputs can work

@duanyytop duanyytop marked this pull request as draft May 17, 2024 12:20
@duanyytop
Copy link
Collaborator Author

Waiting for @Dawn-githup to test a larger and available RGBPP_TX_INPUTS_MAX_LENGTH

@Dawn-githup
Copy link
Contributor

Waiting for @Dawn-githup to test a larger and available RGBPP_TX_INPUTS_MAX_LENGTH

https://www.notion.so/MAX_INPUTS-8ae92108f3d643ae8924711e3524445a

@duanyytop duanyytop marked this pull request as ready for review May 21, 2024 08:11
@duanyytop duanyytop requested review from ahonn and ShookLyngs and removed request for ahonn and ShookLyngs May 21, 2024 08:11
@duanyytop duanyytop merged commit 5edaaf1 into develop May 21, 2024
1 check passed
@duanyytop duanyytop deleted the feat/increase-rgbpp-inputs-length branch May 21, 2024 08:12
@ShookLyngs ShookLyngs mentioned this pull request May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flouse Flouse Flouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duanyytop @Dawn-githup @Flouse