Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular updates todo list #573

Open
1 of 8 tasks
colemanw opened this issue Jun 7, 2021 · 3 comments
Open
1 of 8 tasks

Angular updates todo list #573

colemanw opened this issue Jun 7, 2021 · 3 comments

Comments

@colemanw
Copy link
Member

colemanw commented Jun 7, 2021

  • Use one-time-binding for static content or the output of deterministic functions, e.g. Fix ts() in angular templates to use one-time binding #570
  • Move server-side module definition into an .ang.php file and out of hook_civicrm_angularModules() - revert that function to delegate to _volunteer_civix_civicrm_angularModules() .
  • Break up monolithic "volunteer" Angular module into smaller bite-sized modules.
  • Break up CRM_Volunteer_Page_Angular into front-end and back-end pages, and only load the modules needed for each.
  • Use components instead of directives when possible.
  • Break up monolithic js files into one file per component/directive.
  • Pre-load backbone code on the back-end angular pages instead of depending on the clientside script loading done by angularprofiles (which is broken on some CMS configurations, see civicrm/org.civicrm.contactlayout@24f9a1f)
  • Stop using AJAX to load Angular tab content - core now supports loading it directly
@ginkgomzd
Copy link
Contributor

This looks great

@ginkgomzd ginkgomzd pinned this issue Jun 7, 2021
@ginkgomzd
Copy link
Contributor

Hey, @colemanw ,
Responding to your mattermost msg here because it is easier without a computer.

I'm moving tomorrow and have been short on time this week due to packing.

So, no questions on the PR's yet. If you are holding PR's, you could go ahead and make them and just note the dependency on the order they are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants