From ba1a32a0a7e6dd67666ca7e552515c36f949b784 Mon Sep 17 00:00:00 2001 From: eileen Date: Thu, 4 Feb 2021 16:31:46 +1300 Subject: [PATCH] [REF] Remove unused pcp & soft credit handling from previously shared code the ProcessContribution function has been split out from a shared function used by front end forms and I'm pretty sure it was only relevant for those other forms. The only code that calls this function is when a payment processor is used in recurring mode to pay for a membership. I tested doing this and selected 'record payment from a different contact' without these lines & it created the soft credit (using the code elsewhere in the function that would be used if it were not recurring or not credit card payment) --- CRM/Member/Form/Membership.php | 6 ------ 1 file changed, 6 deletions(-) diff --git a/CRM/Member/Form/Membership.php b/CRM/Member/Form/Membership.php index 0fa3b42564d0..d88a261cfe95 100644 --- a/CRM/Member/Form/Membership.php +++ b/CRM/Member/Form/Membership.php @@ -1907,12 +1907,6 @@ protected function processContribution( $form->_contributionID = $contribution->id; } - // process soft credit / pcp params first - CRM_Contribute_BAO_ContributionSoft::formatSoftCreditParams($params, $form); - - //CRM-13981, processing honor contact into soft-credit contribution - CRM_Contribute_BAO_ContributionSoft::processSoftContribution($params, $contribution); - $transaction->commit(); return $contribution; }