Merge pull request #30694 from JMAConsulting/a11y_fixes_report_2

[REF] Fix empty label accessibility issue on report elements

Author: monishdeb

CRM/Report/Form.php

@@ -1478,7 +1478,7 @@ public function addFilters() {
           default:
             // default type is string
             $this->addElement('select', "{$fieldName}_op", ts('Operator:'), $operations,
-              ['onchange' => "return showHideMaxMinVal( '$fieldName', this.value );"]
+              ['onchange' => "return showHideMaxMinVal( '$fieldName', this.value );", 'title' => ts('%1 Filter Operator', [1 => $field['title']])]
             );
             // we need text box for value input
             $this->add('text', "{$fieldName}_value", NULL, ['class' => 'huge']);
@@ -1695,8 +1695,8 @@ public function addOrderBys() {
           'ASC' => ts('Ascending'),
           'DESC' => ts('Descending'),
         ]);
-        $this->addElement('checkbox', "order_bys[{$i}][section]", ts('Order by Section'), FALSE, ['id' => "order_by_section_$i"]);
-        $this->addElement('checkbox', "order_bys[{$i}][pageBreak]", ts('Page Break'), FALSE, ['id' => "order_by_pagebreak_$i"]);
+        $this->addElement('checkbox', "order_bys[{$i}][section]", ts('Order by Section'), FALSE, ['id' => "order_by_section_$i", 'title' => ts('Order by Section %1', [1 => $i])]);
+        $this->addElement('checkbox', "order_bys[{$i}][pageBreak]", ts('Page Break'), FALSE, ['id' => "order_by_pagebreak_$i", 'title' => ts('Page Break %1', [1 => $i])]);
       }
     }
   }
@@ -1723,7 +1723,7 @@ public function buildInstanceAndButtons() {
       $this->addElement('select', 'groups', ts('Group'),
         ['' => ts('Add Contacts to Group')] +
         CRM_Core_PseudoConstant::nestedGroup(),
-        ['class' => 'crm-select2 crm-action-menu fa-plus huge']
+        ['class' => 'crm-select2 crm-action-menu fa-plus huge', 'title' => ts('Add Contacts to Group')]
       );
       $this->assign('group', TRUE);
     }

CRM/Report/Form/Instance.php

@@ -125,6 +125,7 @@ public static function buildForm(&$form) {
           'size' => 5,
           'style' => 'width:240px',
           'class' => 'advmultiselect',
+          'title' => ts('ACL Group/Role'),
         ]
       );
       $grouprole->setButtonAttributes('add', ['value' => ts('Add >>')]);

templates/CRM/Report/Form/Tabs/Filters.tpl

@@ -37,7 +37,12 @@
                     <td class="label report-contents">{if !empty($field.title)}{$field.title}{/if}</td>
                     <td class="report-contents">{$form.$fieldOp.html}</td>
                     <td>
-                      <span id="{$filterVal}_cell">{$form.$filterVal.label}&nbsp;{$form.$filterVal.html}</span>
+                      <span id="{$filterVal}_cell">
+                        <label class="sr-only" for="{$form.$filterVal.id}">
+                          {if !empty($field.title)}{$field.title}{else}{$field.name}{/if} filter value
+                        </label>
+                        {$form.$filterVal.label}&nbsp;{$form.$filterVal.html}
+                      </span>
                       <span id="{$filterMin}_max_cell">
                         {if array_key_exists($filterMin, $form) && $form.$filterMin}{$form.$filterMin.label}&nbsp;{$form.$filterMin.html}&nbsp;&nbsp;{/if}
                         {if array_key_exists($filterMax, $form) && $form.$filterMax}{$form.$filterMax.label}&nbsp;{$form.$filterMax.html}{/if}