From 207d5372102f47f4bed669977fdd6d573bf627da Mon Sep 17 00:00:00 2001
From: eileen <emcnaughton@wikimedia.org>
Date: Fri, 20 Jul 2018 21:02:25 +1200
Subject: [PATCH] Remove ids from BAO_Product::create (renamed from add) 
 signature altogether

This is actually a new function so we don't need to respect the signature of the deprecated one
---
 CRM/Contribute/BAO/ManagePremiums.php                 | 8 ++++++--
 CRM/Contribute/BAO/Product.php                        | 4 ++--
 CRM/Contribute/Form/ManagePremiums.php                | 2 +-
 tests/phpunit/CRM/Contribute/BAO/ContributionTest.php | 2 +-
 tests/phpunit/CRM/Contribute/BAO/ProductTest.php      | 8 ++++----
 5 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/CRM/Contribute/BAO/ManagePremiums.php b/CRM/Contribute/BAO/ManagePremiums.php
index 35c93959cc6a..a7ba644ff752 100644
--- a/CRM/Contribute/BAO/ManagePremiums.php
+++ b/CRM/Contribute/BAO/ManagePremiums.php
@@ -85,8 +85,12 @@ public static function setIsActive($id, $is_active) {
    * @return CRM_Contribute_DAO_Product
    */
   public static function add(&$params, $ids) {
-    CRM_Core_Error::deprecatedFunctionWarning('CRM_Contribute_BAO_Product::add');
-    return parent::add($params, $ids);
+    CRM_Core_Error::deprecatedFunctionWarning('CRM_Contribute_BAO_Product::create');
+    $id = CRM_Utils_Array::value('id', $params, CRM_Utils_Array::value('premium', $ids));
+    if ($id) {
+      $params['id'] = $id;
+    }
+    return parent::create($params);
   }
 
   /**
diff --git a/CRM/Contribute/BAO/Product.php b/CRM/Contribute/BAO/Product.php
index 008e50e9613a..79d3330458c2 100644
--- a/CRM/Contribute/BAO/Product.php
+++ b/CRM/Contribute/BAO/Product.php
@@ -94,8 +94,8 @@ public static function setIsActive($id, $is_active) {
    *
    * @return CRM_Contribute_DAO_Product
    */
-  public static function add(&$params, $ids = []) {
-    $id = CRM_Utils_Array::value('id', $params, CRM_Utils_Array::value('premium', $ids));
+  public static function create($params) {
+    $id = CRM_Utils_Array::value('id', $params);
     if (empty($id)) {
       $defaultParams = [
         'id' => $id,
diff --git a/CRM/Contribute/Form/ManagePremiums.php b/CRM/Contribute/Form/ManagePremiums.php
index 6c0862bab4b5..c685ee0452d1 100644
--- a/CRM/Contribute/Form/ManagePremiums.php
+++ b/CRM/Contribute/Form/ManagePremiums.php
@@ -294,7 +294,7 @@ public function postProcess() {
     $this->_processImages($params);
 
     // Save to database
-    $premium = CRM_Contribute_BAO_Product::add($params);
+    $premium = CRM_Contribute_BAO_Product::create($params);
 
     CRM_Core_Session::setStatus(
       ts("The Premium '%1' has been saved.", array(1 => $premium->name)),
diff --git a/tests/phpunit/CRM/Contribute/BAO/ContributionTest.php b/tests/phpunit/CRM/Contribute/BAO/ContributionTest.php
index f21a3d9927b4..83d94b00411b 100644
--- a/tests/phpunit/CRM/Contribute/BAO/ContributionTest.php
+++ b/tests/phpunit/CRM/Contribute/BAO/ContributionTest.php
@@ -372,7 +372,7 @@ public function testAddPremium() {
       'min_contribution' => 100,
       'is_active' => 1,
     );
-    $premium = CRM_Contribute_BAO_Product::add($params);
+    $premium = CRM_Contribute_BAO_Product::create($params);
 
     $this->assertEquals('TEST Premium', $premium->name, 'Check for premium  name.');
 
diff --git a/tests/phpunit/CRM/Contribute/BAO/ProductTest.php b/tests/phpunit/CRM/Contribute/BAO/ProductTest.php
index 3b7e8eda2e58..6779d29be978 100644
--- a/tests/phpunit/CRM/Contribute/BAO/ProductTest.php
+++ b/tests/phpunit/CRM/Contribute/BAO/ProductTest.php
@@ -49,7 +49,7 @@ public function testAdd() {
       'is_active' => 1,
     );
 
-    $product = CRM_Contribute_BAO_Product::add($params);
+    $product = CRM_Contribute_BAO_Product::create($params);
 
     $result = $this->assertDBNotNull('CRM_Contribute_BAO_Product', $product->id,
       'sku', 'id',
@@ -73,7 +73,7 @@ public function testRetrieve() {
       'is_active' => 1,
     );
 
-    $product = CRM_Contribute_BAO_Product::add($params);
+    $product = CRM_Contribute_BAO_Product::create($params);
     $params = array('id' => $product->id);
     $default = array();
     $result = CRM_Contribute_BAO_Product::retrieve($params, $default);
@@ -94,7 +94,7 @@ public function testSetIsActive() {
       'is_active' => 1,
     );
 
-    $product = CRM_Contribute_BAO_Product::add($params);
+    $product = CRM_Contribute_BAO_Product::create($params);
     CRM_Contribute_BAO_Product::setIsActive($product->id, 0);
 
     $isActive = $this->assertDBNotNull('CRM_Contribute_BAO_Product', $product->id,
@@ -119,7 +119,7 @@ public function testDel() {
       'is_active' => 1,
     );
 
-    $product = CRM_Contribute_BAO_Product::add($params);
+    $product = CRM_Contribute_BAO_Product::create($params);
 
     CRM_Contribute_BAO_Product::del($product->id);