From 4586a81f8d474b54d05d9b6ff3a7fc9aedc10730 Mon Sep 17 00:00:00 2001 From: eileen Date: Sat, 1 Aug 2020 16:06:40 +1200 Subject: [PATCH] dev/core#1921 [Ref] remove isoToMysql It used to be necessary (until maybe 5 years ago) to reformat retrieved date params before re-saving https://lab.civicrm.org/dev/core/-/issues/1921 --- CRM/Core/Payment/BaseIPN.php | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/CRM/Core/Payment/BaseIPN.php b/CRM/Core/Payment/BaseIPN.php index 8b2d72ba52f4..ea0111d846ff 100644 --- a/CRM/Core/Payment/BaseIPN.php +++ b/CRM/Core/Payment/BaseIPN.php @@ -224,21 +224,9 @@ public function failed(&$objects, $transaction = NULL, $input = []) { } } - $addLineItems = FALSE; - if (empty($contribution->id)) { - $addLineItems = TRUE; - } + $addLineItems = empty($contribution->id); $participant = &$objects['participant']; - - // CRM-15546 - $contributionStatuses = CRM_Core_PseudoConstant::get('CRM_Contribute_DAO_Contribution', 'contribution_status_id', [ - 'labelColumn' => 'name', - 'flip' => 1, - ]); - $contribution->contribution_status_id = $contributionStatuses['Failed']; - $contribution->receive_date = CRM_Utils_Date::isoToMysql($contribution->receive_date); - $contribution->receipt_date = CRM_Utils_Date::isoToMysql($contribution->receipt_date); - $contribution->thankyou_date = CRM_Utils_Date::isoToMysql($contribution->thankyou_date); + $contribution->contribution_status_id = CRM_Core_PseudoConstant::getKey('CRM_Contribute_DAO_Contribution', 'contribution_status_id', 'Failed'); $contribution->save(); // Add line items for recurring payments.