-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix small issue in apa.csl #5071
Conversation
Hi @bwiernik Was just working on a style based on apa.csl and came across this mistake.
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
😟 There are some issues with your submission. Please check the test report for details. |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: apa.csl (modified style)(CSL Search by Example, 2012; Hancké et al., 2007) (<i>CSL Search by Example</i>, 2012; Hancké et al., 2007)<br/>
(Fenner et al., 2019; Mares, 2001)<br/>
<hr/>
-<i>CSL search by example</i>. (2012). http://editor.citationstyles.org/searchByExample/<br/>
+<i>CSL search by example</i>. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/<br/>
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. <i>Scientific Data</i>, <i>6</i>(1), 28. https://doi.org/10.1038/s41597-019-0031-8<br/>
Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>. Oxford University Press.<br/>
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), <i>Varieties of capitalism. The institutional foundations of comparative advantage</i> (pp. 184–213). Oxford University Press.<br/>
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: apa.csl (modified style)(CSL Search by Example, 2012; Hancké et al., 2007) (<i>CSL Search by Example</i>, 2012; Hancké et al., 2007)<br/>
(Fenner et al., 2019; Mares, 2001)<br/>
<hr/>
-<i>CSL search by example</i>. (2012). http://editor.citationstyles.org/searchByExample/<br/>
+<i>CSL search by example</i>. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/<br/>
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. <i>Scientific Data</i>, <i>6</i>(1), 28. https://doi.org/10.1038/s41597-019-0031-8<br/>
Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>. Oxford University Press.<br/>
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), <i>Varieties of capitalism. The institutional foundations of comparative advantage</i> (pp. 184–213). Oxford University Press.<br/>
|
Huh, I could have sworn I had cleaned up all of these. I'll open a PR later today that fixes these and the rest of the apa flavors. |
(It looks like there are a few other places where there are multiple types without match="any") |
I'll close this PR once you open yours then. :-) |
@bwiernik -- this is still on your radar, yes? No huge rush, but don't want it to get lost. |
Yep on my radar |
Closes citation-style-language#5071 Co-Authored-By: POBrien333 <954979+POBrien333@users.noreply.github.com>
Opened a new PR. Thanks for catching this @POBrien333 ! |
Closes #5071 Co-authored-by: POBrien333 <954979+POBrien333@users.noreply.github.com>
Hi @bwiernik
Was just working on a style based on apa.csl and came across this mistake.
At least the visual editor defaults the missing "match" attribute to a
match="and"
.