replace exit() with sys.exit() #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
isn't |
|
@darodi Mind finalizing v5.6.3 as is so we don't get questions in the future from people who initially downloaded v5.6.2 since it shows up first like in #591 v5.6.3 has proved pretty stable so far.
However, don't include this PR in it. I finally managed to replicate this. Fixing this issue now makes the app exit silently instead of throwing an error 😓 I placed KCC.exe in the KP3 directory. |
|
I can only test it at the end of next week because I am not at home right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary EXE here: https://github.com/axu2/kcc/actions/runs/6125895319
Please test to confirm it works.
Make sure you test in multiple locations like on your desktop.