-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crop images within 3% of device aspect ratio #495
Conversation
On further inspection I think this PR is big enough. I recommend squashing my commits. |
forced pushed a rebase on master with squash and some refactoring |
Since you already started refactoring, I may as well add the cbz case as well from #471 |
While we are at it, maybe we should remove the BICUBIC filter. Looks like in the past BICUBIC was better for upscaling but not anymore. This might be a separate PR/logical step though. I personally don't use upscale on the Kindle Scribe since the Scribe will fill the screen no matter what the original size was.
https://pillow.readthedocs.io/en/stable/releasenotes/2.7.0.html |
Lanczos might produce slightly more ringing than bicubic. |
Yea definitely a separate PR then, if we decide to change. I personally think it's probably better to not change. |
Because filling the screen with double page spreads looks amazing on the new Kindle Scribe with its 4:3 aspect ratio. (even though the images are downscaled to 1920x1440 per
Also, replaces previous code that could potentially resize images twice, leading to quality loss, instead just using library functions to do it in one pass.
The problem becomes more serious the smaller the edge is.
Here is what the maximum crop looks like: