Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates GUI text for new Homebrew version #491

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

thatrobotdev
Copy link
Contributor

The instructions in the GUI for downloading the kindle-comic-creator cask utilize an old brew command, so this PR updates the GUI text with the command that Homebrew uses now. It also renames references to "Brew" to "Homebrew".

Screenshot of the GUI with the old command


This is what current homebrew tells you if you use the old command that the GUI suggests:

jameskerrane@Jamess-MBP ~> brew cask install kindle-comic-creator
Error: `brew cask` is no longer a `brew` command. Use `brew <command> --cask` instead.

This is a successful installation with the command that I changed the GUI instructions to:

jameskerrane@Jamess-MBP ~ [1]> brew install --cask kindle-comic-creator
==> Downloading https://kc2.s3.amazonaws.com/KindleComicCreatorInstall.dmg
Already downloaded: /Users/jameskerrane/Library/Caches/Homebrew/downloads/29bff483a8f694859b20eacf3cd654d0565c07fc31165f9ba8408c3f88edb26a--KindleComicCreatorInstall.dmg
Warning: No checksum defined for cask 'kindle-comic-creator', skipping verification.
==> Installing Cask kindle-comic-creator
==> Running installer for kindle-comic-creator; your password may be necessary.
Package installers may write to any location; options such as `--appdir` are ignored.
Password:
installer: Package name is Kindle Comic Creator
installer: Installing at base path /
installer: The install was successful.
🍺  kindle-comic-creator was successfully installed!

@darodi darodi merged commit 56f6c69 into ciromattia:master Mar 27, 2023
@darodi darodi added this to the 5.6.2 milestone Mar 27, 2023
@axu2
Copy link
Collaborator

axu2 commented Jul 1, 2023

@thatrobotdev

Just a nitpick, since you can't copy paste from the UI, might be better to change the wording and link to a wiki page instead.

@thatrobotdev
Copy link
Contributor Author

thatrobotdev commented Jul 4, 2023

A direct link to this wiki page might be nice, although for users already familiar with Homebrew I appreciate the cask name being mentioned in the app- https://github.com/ciromattia/kcc/wiki/Installation#mac

Maybe something like, "Cannot find Kindle Comic Creator! Install the 'kindle-comic-creator' cask using Homebrew to enable MOBI conversion".

It looks like the original link to KindleGen is defunct, so this would also (solve?) that issue. (I'm confused reading through these issues, is it still recommended to install KindleGen from an unauthorized/archived source? #449 (comment))

Relevant lines

self.addMessage('Cannot find <a href="http://www.amazon.com/gp/feature.html?ie=UTF8&docId='
'1000765211"><b>KindleGen</b></a>! MOBI conversion is unavailable!', 'error')
if sys.platform.startswith('win'):
self.addMessage('Download it and place EXE in KCC directory.', 'error')
elif sys.platform.startswith('darwin'):
self.addMessage('Install it using <a href="http://brew.sh/">Homebrew</a>.', 'error')

@thatrobotdev thatrobotdev deleted the brew-gui-change branch July 4, 2023 15:21
@darodi
Copy link
Collaborator

darodi commented Jul 5, 2023

@thatrobotdev

I made a PR:

Can you tests if this is ok for you?
I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants