-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Custom Margin #870
Comments
Does the old cropping method give the same result? The old cropping method was still in KCC 6.3.1 |
I tested with 6.3.1 just now and I think it's a bit better, it left a few extra lines of white margin. But it seems like a useful feature to have the option for custom margins. I would still have added an extra 5-10px if it was up to me. I'm not super sure what resolution i'm working with here. but a bit more would be nice for this series. |
Are you doing partially checked or fully checked? send full settings screenshot @neyney10 in case this interests you. |
Yes, it would be nice to combine the small white margins left after cropping from KCC 6.3.1 with the cool page number cropping from KCC 7+ |
The newer cropping algorithm crops more tightly around the main content and hence results in a tighter image (relative to the screen edges). I see two options:
Would it be better to let the user define the desired margins in
|
I would vote for number of pixels. You already have UI precedence for input boxes when the user selects the “other” device type, you could go with that. I’d also suggest different top and bottom pixel counts. I’d love to use the “progress bar” feature of Kobo devices without it covering up some of the image at the bottom. |
If you decide to go this way, you could just not add extra margin in those cases |
I'm not sure I understand what you mean by "UI precedence for input boxes". Different sizes for each margin seem like a good idea (maybe including also left & right margins?). Maybe we can combine the two and set a toggle to swap between pixel units and % units.
The reason I add this is because what if the image is already cropped and there is nothing more to crop? and hence the algorithm would crop zero pixels. In such a scenario it doesn't have any crop to "undo", and to make sure that there are X pixels of margin, it has to add them anew. |
All I meant was that KCC has used input boxes before, so it doesn't HAVE to be sliders. But percent could work just fine, I see what you're saying. |
I'm trying to convert a comic that uses speech bubbles that are open to the edge of the page (Invincible if you want to take a look). That means that when they are on the top or bottom of the page the letters are the first/final pixel of the image which makes a bit hard to read.
I thought that Cropping Power would adjust that but it looks like it doesn't. I ran the conversion with power .05 and with power 3 and both produced the same result.
Could you add a setting to retain (or add back) a custom amount of margin to the top and bottom to help alleviate this? Maybe measured in pixels or something.
The text was updated successfully, but these errors were encountered: