Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding support for checkout/3 (Ecto 3) #33

Open
darrenklein opened this issue Feb 23, 2020 · 0 comments
Open

Consider adding support for checkout/3 (Ecto 3) #33

darrenklein opened this issue Feb 23, 2020 · 0 comments
Labels
help wanted question to-do Features/tasks that we'd like to add to the adapter.

Comments

@darrenklein
Copy link
Contributor

darrenklein commented Feb 23, 2020

As of the initial alpha release with Ecto 3 support, 624bffb, we do not support checkout/3 - checkout/3 is a @callback that was implemented in Ecto 3 for Ecto.Adapter, but it was not critical to making the upgrade from Ecto 2 to Ecto 3 support.

At the moment, we raise in the event that a user calls this method:

@impl Ecto.Adapter
def checkout(_meta, _opts, _fun) do
  # TODO - consider adding support for this?
  raise "#{inspect __MODULE__}.checkout: #{inspect __MODULE__} does not currently support checkout"
end

Is Ecto's concept of checkout something that is conceptually appropriate to adapt for use in DynamoDB? If so, it should be addressed; otherwise, continuing to raise is probably fine.

@darrenklein darrenklein added help wanted question to-do Features/tasks that we'd like to add to the adapter. labels Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted question to-do Features/tasks that we'd like to add to the adapter.
Projects
None yet
Development

No branches or pull requests

1 participant