Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not delete entitiy fields in datastore when those entity keys are missing from the Entity model #3

Open
chaitanyanettem opened this issue Oct 9, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@chaitanyanettem
Copy link
Contributor

chaitanyanettem commented Oct 9, 2019

This becomes an issue when different Entity models are being used by different services to represent the same Entity. (It is a separate problem that the models shouldn't be different 🤔 but let's not go there).

For eg -

  • In service A, the car Entity is defined as -
class Car(BaseModel):
    price: int = 5000
  • In service B, the car Entity is defined as -
class Car(BaseModel):
    price: int = 10000
    brand: str = 'BMW'

if service A updates an entity which has the brand field, it should not remove the brand field.

@chaitanyanettem chaitanyanettem added the bug Something isn't working label Oct 9, 2019
@chaitanyanettem chaitanyanettem self-assigned this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant