(DRAFT) Fix global notification rules by using /pushrules instead of /m.push_rules #2093
Conversation
The ability to set account for event types changed. See https://spec.matrix.org/v1.12/client-server-api/#server-behaviour-12. The correct api is documented here: https://spec.matrix.org/v1.12/client-server-api/#push-rules-api. fixes cinnyapp#2034
|
Preview: https://2093--pr-cinny.netlify.app |
LevitatingBusinessMan
changed the title
|
Hmm I am not entirely sure that it is applying the setting correctly in practice. I will have to do a bit more testing. |
|
I don't know how matrix-js-sdk works, but the change looks completely wrong (unless matrix-js-sdk has some weird hacks that make it work)
Getting push rules via account data calls should be fine though |
|
Hmm @tulir I think you're right and I will dig into it a bit deeper. I kind of just winged this change, and superficially it appeared to work. There's no errors or warnings created, setting the data with And I thought the code also fetched the set value, but it doesn't and the changed value appears to only be present locally. I'll mark the PR a draft and then redo it sometime next week. |
LevitatingBusinessMan
changed the title
|
I am working on the settings rework and currently going through notifications section, its going to fix in it. #1988 |
|
Great, in that case I'll just close this. |
Description
The ability to set account for event types changed. See https://spec.matrix.org/v1.12/client-server-api/#server-behaviour-12.
The correct api is documented here: https://spec.matrix.org/v1.12/client-server-api/#push-rules-api.
fixes #2034
Type of change
Checklist: