Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmtests: pkg.sensors.tracing:TestKprobeRateLimit and NoRateLimit are failing silently because of panic in tests #2686

Closed
2 tasks done
mtardy opened this issue Jul 17, 2024 · 0 comments · Fixed by #2685
Closed
2 tasks done
Labels
area/ci Related to CI

Comments

@mtardy
Copy link
Member

mtardy commented Jul 17, 2024

I realized that the test was failing while writing the v1.0 backport #2584. Only to realize later that it was also failing on main and v1.1, while the vmtests recap being green (for example see, a v1.1 run or a main run). So it was failing everywhere because nc.openbsd was missing.

So it seemed that when tests panic, they are failing according to vmtests but not counted toward the total. The only remaining question is: what is the difference between v1.0 and v1.1/main?

So I see a few things:

Also the test is really slow on success (40s+) because it tries to check for missing events (so it's retrying multiple time, it should be optimized not to make the test suite too slow.

@mtardy mtardy added the area/ci Related to CI label Jul 17, 2024
@mtardy mtardy changed the title vmtests: pkg.sensors.tracing:TestKprobeRateLimit and NoRateLimit are failing silently vmtests: pkg.sensors.tracing:TestKprobeRateLimit and NoRateLimit are failing silently because of panic in tests Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Related to CI
Projects
None yet
1 participant