-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to glimmer-vm@0.36.2? #23
Comments
From version 0.4.0 |
As mentioned in emberjs/ember.js#16269 I'm running ember-ast-helpers@0.4.0 & glimmer@0.35.10, but I'm still getting @musaffa @cibernox any cue on what's going on? Thanks. |
Are you using any dependency that depends on ember-ast-helpers@<0.4.0? Are you using ember-fontawesome? |
No, I'm using a fork of ember-font-awesome which depends on ember-ast-helpers@0.4.0. The relevant parts of my
Thanks. |
Instead of using the forked repo, you could just use the resolution feature of "resolutions": {
"ember-font-awesome/**/ember-ast-helpers": "^0.4.0"
} I'm also using this resolution feature with |
Right; thanks for the trick, but the fork also addresses a change in implementation for ember-ast-helpers@0.4.0. I looked at @fortawesome/ember-font awesome a few months ago for Font Awesome 5 support, but it requires too many changes for my immediate need and I don’t think that’s where the issue is. |
I started seeing issue emberjs/ember.js#16269 quite often in my production logs yesterday when I upgraded from ember-source@3.1.1 to ember-source@3.3.2.
A fix (emberjs/ember.js#16286) was released in glimmer-vm@0.32.1 but ember-font-awesome uses ember-ast-helpers@0.3.5 which locks @ember/compiler to ^0.27.0.
Is there a reason why this is locked to glimmer 0.27.x ?
The text was updated successfully, but these errors were encountered: