-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API break in client/server creation #271
Comments
Obviously you are in 0.x.y semantic versioning so breakage is expected but just wanted to make sure you were aware. If this is intended, I'll open a ticket with pytradfri. |
Thanks, that was not intended -- 0.x or not, reasonable use of aiocoap should not break w/o a deprecation over a number.
I'll look into it.
|
I'm presently on it :-) |
Yay! Thank you very much |
Phew, that's a tough one, for it seems I can't properly subclass a coroutine in Python -- and the preferred pattern for proper shutdown is would be I'm leaning towards just fessing up to this API change ("you can await it for compatibility reason, so your code will keep working unless you directly place the awaitable into a Would it be feasible for you to lockstep this in a pytradfri update? I'm not sure what the intention behind the code is there as it is (I'd just make |
Proposed a fix in home-assistant-libs/pytradfri#536 that AIU should be usable both for the old and the new aiocoap version. If it works out here, it'd reassure me in making this small breaking API change and point to that PR as a reference fix (for those who can't easily go the async context manager route). |
Based on discussion in home-assistant-libs/pytradfri#536 I'm fixing this by rolling back the offending commit. Thanks to you and @MartinHjelmare for your input on that matter. |
Great stuff, thank you! |
The current master branch is about to become 0.4.4, could you give it a test run to verify that your issues were addressed before I push the button? |
In fixing #269 the same user tested my PR and found that a different Home Assistant component, pytradfri, broke due to an API change around client/server creation:
Stacktrace copy/pasted here:
The text was updated successfully, but these errors were encountered: