-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nanosecond Timestamps #247
Conversation
hmm, that clippy failure seems to be due to clippy adding new checks given that it is not in any code that I have touched. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the single request for a name change this looks great.
The Clippy failure is a known bug in Clippy, not your fault and it won't block merging.
src/datetime.rs
Outdated
/// # } | ||
/// # fn main() { example().unwrap(); } | ||
/// ``` | ||
pub mod ts_nano_seconds { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just treat this as a single word ts_nanoseconds
Oh could you add yourself to the CHANGELOG, too? |
What additions to the changelog file should I make? |
Ok, renamed and added a few lines to CHANGELOG.md |
Great, thanks! I'll publish this in a release by this weekend. |
Microseconds Timestamps, clone of #247
This merge requests adds a function for retrieving a DateTime as nanoseconds elapsed since the Unix Epoch. It also adds serde functions for serialising/serialising DateTime objects from nanosecond timestamps.