Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanosecond Timestamps #247

Merged
merged 4 commits into from
May 24, 2018
Merged

Conversation

HarkonenBade
Copy link
Contributor

This merge requests adds a function for retrieving a DateTime as nanoseconds elapsed since the Unix Epoch. It also adds serde functions for serialising/serialising DateTime objects from nanosecond timestamps.

@HarkonenBade
Copy link
Contributor Author

hmm, that clippy failure seems to be due to clippy adding new checks given that it is not in any code that I have touched.

Copy link
Contributor

@quodlibetor quodlibetor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the single request for a name change this looks great.

The Clippy failure is a known bug in Clippy, not your fault and it won't block merging.

src/datetime.rs Outdated
/// # }
/// # fn main() { example().unwrap(); }
/// ```
pub mod ts_nano_seconds {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just treat this as a single word ts_nanoseconds

@quodlibetor
Copy link
Contributor

Oh could you add yourself to the CHANGELOG, too?

@HarkonenBade
Copy link
Contributor Author

What additions to the changelog file should I make?

@HarkonenBade
Copy link
Contributor Author

Ok, renamed and added a few lines to CHANGELOG.md

@quodlibetor
Copy link
Contributor

Great, thanks! I'll publish this in a release by this weekend.

@quodlibetor quodlibetor merged commit 9276929 into chronotope:master May 24, 2018
quodlibetor added a commit that referenced this pull request Nov 13, 2020
Microseconds Timestamps, clone of #247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants