Commits on Mar 29, 2018

1. Deprecated warnings in cargo output for rustc-serialize feature …

   Unfortunately due to rust-lang/rust#39935 placing the annotation on the `impl`s
   of `Encodable`/`Decodable` for the various items have no effect whatsoever, so
   we need to place it on some type that chrono actually uses internally. The only
   *type* that I can find that only exists for rustc-serialize only is the
    `TsSeconds` struct.
   
   So, marking TsSeconds deprecated causes Chrono's internal uses of `TsSeconds`
   to emit deprecation warnings, both in our builds and for packages that specify
   Chrono as a dependency with the `rustc-serialize` feature active. This means
   that the current commit will cause a `warning: use of deprecated item:
   RustcSerialize will be removed before chrono 1.0, use Serde instead` to appear
   in `cargo build` output.
   
   Unfortunately I don't think that it's possible for downstream crates to disable
   the warning the warning in any way other than actually switching to Serde or
   using an older chrono. That's the reason for all the `#[allow(deprecated)]`
   through the code, it means that the warning appears almost exactly once,
   instead of dozens of times.

   

   quodlibetor committed Mar 29, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 39ca2e6
   • Browse repository at this point

   Copy the full SHA

   39ca2e6 View commit details

   Browse the repository at this point in the history