Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only package files needed for building and testing #1554

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

pitdicker
Copy link
Collaborator

Compared to what we packaged before we now skip those files:

.git-ignore-revs
.github/codecov.yml
.github/dependabot.yml
.github/pull_request_template.md
.github/workflows/codecov.yml
.github/workflows/lint.yml
.github/workflows/test.yml
.gitignore
CHANGELOG.md
CITATION.cff
deny.toml
rustfmt.toml
taplo.toml

Also we had a leftover appveyor.yml file. Not sure why it was not deleted outright in #436.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (8b1364f) to head (24e0e5e).

❗ Current head 24e0e5e differs from pull request most recent head 857a9d3. Consider uploading reports for the commit 857a9d3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1554   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files          37       37           
  Lines       18167    18167           
=======================================
  Hits        16674    16674           
  Misses       1493     1493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should maybe ship CITATION.cff? Not sure how that gets used but I can see how that might be useful.

@pitdicker pitdicker merged commit 7f57dde into chronotope:main Apr 4, 2024
32 of 33 checks passed
@pitdicker pitdicker deleted the cargo_include branch April 4, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants