Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove format::{format_localized, format_item_localized} #1311

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

pitdicker
Copy link
Collaborator

I forgot that in #1306 format::{format_localized, format_item_localized} are behind the unstable-locales feature. Instead of deprecating I think we can just removed them.
That is what it did in the PR the commit was based on, but I messed up.

@pitdicker
Copy link
Collaborator Author

Also I can't imagine anyone has ever used these.

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #1311 (c1a559e) into 0.4.x (68a141e) will increase coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            0.4.x    #1311      +/-   ##
==========================================
+ Coverage   91.00%   91.20%   +0.20%     
==========================================
  Files          38       38              
  Lines       17068    17030      -38     
==========================================
  Hits        15533    15533              
+ Misses       1535     1497      -38     
Files Changed Coverage Δ
src/format/formatting.rs 92.53% <ø> (+4.70%) ⬆️
src/format/mod.rs 85.04% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pitdicker pitdicker merged commit 4d28a89 into chronotope:0.4.x Sep 23, 2023
37 checks passed
@pitdicker pitdicker deleted the remove_format_item_localized branch September 23, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants