Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

about support for storybook package for vue3 #292

Closed
nisshii0313 opened this issue Feb 26, 2021 · 5 comments
Closed

about support for storybook package for vue3 #292

nisshii0313 opened this issue Feb 26, 2021 · 5 comments
Labels
customer reported Tracking: This issue was reported through customer support enhancement Classification: New feature or request tiny Estimate: <= 2 hours

Comments

@nisshii0313
Copy link
Contributor

nisshii0313 commented Feb 26, 2021 •
edited by sync-by-unito bot
Loading

Hello everyone.
In the vue community, there seems to be a movement to release a storybook package for vue3 as "@storybook/vue3".
(cf: storybookjs/storybook#10654 (comment))

Is there any plan to support this movement in chromatic-cli?

(For example, I think we can add "vue3" to "viewLayers" here.

chromatic-cli/bin/lib/getStorybookInfo.js

Line 5 in d17864b

const viewLayers = [
)

Please let me know if I've misunderstood something. Thanks 😃

┆Issue is synchronized with this Asana task by Unito
@tmeasday tmeasday added the enhancement Classification: New feature or request label Mar 1, 2021
@tmeasday
Copy link
Member

tmeasday commented Mar 1, 2021

Sounds like a good idea @nisshii0313

@tmeasday tmeasday added P0 tiny Estimate: <= 2 hours labels Mar 4, 2021
@tmeasday tmeasday added this to the Q1 Improvements milestone Mar 4, 2021
@tmeasday tmeasday added the customer reported Tracking: This issue was reported through customer support label Mar 4, 2021
@tmeasday
Copy link
Member

tmeasday commented Mar 4, 2021

@nisshii0313 you are right! Want to send a PR?

@nisshii0313
Copy link
Contributor Author

nisshii0313 commented Mar 4, 2021 •
edited
Loading

@tmeasday Yes, I want to send.

@nisshii0313 nisshii0313 mentioned this issue Mar 4, 2021
Merged
@nisshii0313
Copy link
Contributor Author

I sent a PR from my forked repository. I hope you will check it out. 👍

@sync-by-unito sync-by-unito bot reopened this Mar 25, 2021
@tmeasday
Copy link
Member

Released in 5.7.0

@tmeasday tmeasday removed this from the Q1 Improvements milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer reported Tracking: This issue was reported through customer support enhancement Classification: New feature or request tiny Estimate: <= 2 hours
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmeasday @nisshii0313