Add isolatorURL to action outputs

[ndelangen]

The output could be added, the isolatorURL (where the iframe.html is hosted) is saved on the 'context' here:

chromatic-cli/bin/tasks/start.js

Line 22 in c6964c9

ctx.isolatorUrl = url;

The resulting context can be extracted here:

chromatic-cli/action/main.ts

Line 86 in c6964c9

code: ctx.exitCode,

Then set as an output for the action here:

chromatic-cli/action/main.ts

Lines 147 to 149 in c6964c9

	const [{ url, code }] = await Promise.all([chromatic]);
	setOutput('url', url);

┆Issue is synchronized with this Asana task by Unito

[deebov]

may I know why this issue was closed? Because the storybookUrl that's exposed to the output is wrong (empty).

This should be ctx.isolatorUrl instead of ctx.build.isolatorUrl:

chromatic-cli/action/main.ts

Line 84 in 0c4ed31

storybookUrl: ctx.build?.isolatorUrl,

Where (I suppose) the actual link to isolatorUrl is set:

chromatic-cli/bin/tasks/upload.js

Line 124 in 0c4ed31

ctx.isolatorUrl = new URL('/iframe.html', domain).toString();

[ghengeveld]

This should be ctx.build?.cachedUrl

isolatorUrl isn't guaranteed to be around forever (i.e. when using a tunnel).

[ndelangen]

ow! no!

[ndelangen]

should be an easy fix then right @ghengeveld ?

[ghengeveld]

Yes, just use cachedUrl. isolatorUrl isn't something that should be used after the build is done.

[deebov]

Thanks for reopening this.

Should I make a PR?

[ndelangen]

I'll do it today!

[ndelangen]

@ghengeveld I think that was released now?