From d2bdfc89c7843b2addee3da3aac67e45ca048fc5 Mon Sep 17 00:00:00 2001 From: Cody Kaup Date: Thu, 17 Oct 2024 11:19:24 -0500 Subject: [PATCH] Update default log location for E2E --- node-src/lib/getOptions.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/node-src/lib/getOptions.ts b/node-src/lib/getOptions.ts index 4bdef6bd2..39e413cc1 100644 --- a/node-src/lib/getOptions.ts +++ b/node-src/lib/getOptions.ts @@ -119,6 +119,7 @@ export default function getOptions(ctx: InitialContext): Options { const DEFAULT_REPORT_FILE = 'chromatic-build-{buildNumber}.xml'; const DEFAULT_DIAGNOSTICS_FILE = 'chromatic-diagnostics.json'; const DEFAULT_STORYBOOK_LOG_FILE = 'build-storybook.log'; + const DEFAULT_E2E_LOG_FILE = 'build-archive.log'; // We need to strip out undefined because they otherwise they override anyway const optionsFromFlags = stripUndefined({ @@ -164,7 +165,11 @@ export default function getOptions(ctx: InitialContext): Options { storybookBuildDir: takeLast(flags.storybookBuildDir), storybookBaseDir: flags.storybookBaseDir, storybookConfigDir: flags.storybookConfigDir, - storybookLogFile: defaultUnlessSet(flags.storybookLogFile, DEFAULT_STORYBOOK_LOG_FILE), + // We should rename this flag so it makes more sense in E2E contexts + storybookLogFile: + flags.playwright || flags.cypress + ? defaultUnlessSet(flags.storybookLogFile, DEFAULT_E2E_LOG_FILE) + : defaultUnlessSet(flags.storybookLogFile, DEFAULT_STORYBOOK_LOG_FILE), ownerName: branchOwner || repositoryOwner, repositorySlug: flags.repositorySlug,