This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
feat(connection): attempt both ipv6 and ipv4 when no family entered #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daprahamian
force-pushed
the
NODE-1222
branch
from
a1ac129 to
5cc188b
Compare
daprahamian
changed the title
|
Removed WIP, this should be ready for review |
daprahamian
force-pushed
the
NODE-1222
branch
2 times, most recently
from
37def16 to
239cac9
Compare
jlord
suggested changes
Dec 19, 2017
| @@ -0,0 +1,127 @@ | |||
| 'use strict'; | |||
|
|
|||
| var bson = require('bson'); | |||
lib/connection/connection.js
Outdated
| self.responseOptions.promoteValues = _options.promoteValues; | ||
| self.responseOptions.promoteBuffers = _options.promoteBuffers; | ||
| function makeSSLConnection(self, _options) { | ||
| var sslOptions = { |
If the user does not specify an IP family, we will attempt to connect first via IPv6, and fall back to IPv4 if that fails Fixes NODE-1222
daprahamian
force-pushed
the
NODE-1222
branch
from
239cac9 to
bd931e5
Compare
|
Updated to remove |
mbroadst
approved these changes
Dec 19, 2017
jlord
approved these changes
Dec 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user does not specify an IP family, we will attempt to
connect first via IPv6, and fall back to IPv4 if that fails
Currently WIP as I need to write unit tests for this.