Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying access modifiers for generated classes #20

Closed
kirides opened this issue Apr 24, 2023 · 2 comments · Fixed by #21
Closed

Allow specifying access modifiers for generated classes #20

kirides opened this issue Apr 24, 2023 · 2 comments · Fixed by #21
Assignees
Labels
enhancement New feature, bug fix, or request

Comments

@kirides
Copy link
Contributor

kirides commented Apr 24, 2023

First off, sorry for feature bombing

It would be very handy to be able to specify the access modifier for the generated DTOs and Clients.

backstory:

In our project, we have modularized everything and try to keep our public Api surface as small as possible.
We define most of our classes as internal unless they explicitly are needed in other places.

All HTTP calls a module needs and all their DTOs reside in the module and never leave it's scope.

@christianhelle christianhelle self-assigned this Apr 24, 2023
@christianhelle
Copy link
Owner

christianhelle commented Apr 24, 2023

@kirides thank you for your input

Yes, it is possible to generate the interface API and contract types as internal. I can expose this in some CLI arguments, but the default will be public

@christianhelle christianhelle added the enhancement New feature, bug fix, or request label Apr 24, 2023
@christianhelle
Copy link
Owner

@kirides I have implemented this and will release it tonight (CEST)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants