Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow nav links with depth more than 2 #1

Closed
jeffpeiyt opened this issue Nov 20, 2015 · 12 comments
Closed

allow nav links with depth more than 2 #1

jeffpeiyt opened this issue Nov 20, 2015 · 12 comments

Comments

@jeffpeiyt
Copy link
Contributor

this theme is really cool and much better than the mkdocs default one!

One issue would be very nice to address is to support more than a 2nd level of navigation. Actually current mkdcos/readthedocs theme actually already support it. Could we make it working with Cinder?

I tried it does not work at this point. Thanks!!

https://www.bountysource.com/issues/2321017-allow-nav-links-with-depth-2

https://groups.google.com/forum/m/#!msg/mkdocs/rU73ZC1BKis/L9C513KVd3sJ

@jeffpeiyt
Copy link
Contributor Author

I checked it, the issue is in base.css hopefully the work is not too much given a diff

@jeffpeiyt
Copy link
Contributor Author

when I just copy over boostrap.*.css it works. just the alignment of the >2 level menu was a little issue

@jeffpeiyt
Copy link
Contributor Author

added pull request #2

@chrissimpkins
Copy link
Owner

do you have this working on an example site?

@jeffpeiyt
Copy link
Contributor Author

I have one internal site. but let me add one similar to this: http://www.parallec.io/docs/ . 10 minutes

@chrissimpkins
Copy link
Owner

no rush at all. thanks!

@jeffpeiyt
Copy link
Contributor Author

here you go: http://www.parallec.io/testdoc/test/test/test/

check the drop down of "test" column

@chrissimpkins
Copy link
Owner

Arrow in the dropdown seems to be too low in FF 44.0a2:

dropdown-ss

This looks great though. Should be a simple fix. Thanks for adding it!

@jeffpeiyt
Copy link
Contributor Author

ah. thanks for catching this in FF. I should have tried in all browsers

@jeffpeiyt
Copy link
Contributor Author

ah... I fixed it... let me see how to submit a pull request / combine with the previous one.

@jeffpeiyt
Copy link
Contributor Author

tested in IE/Safari/FF/Chrome

http://www.parallec.io/testdoc/

@chrissimpkins
Copy link
Owner

Looks great! Merged. Will add it to the release. Thank you very much for contributing this. I really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants