Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug : Long Titles in Blog Page #43

Closed
Elwafi-Elmehdi opened this issue Jan 31, 2023 · 9 comments
Closed

Bug : Long Titles in Blog Page #43

Elwafi-Elmehdi opened this issue Jan 31, 2023 · 9 comments

Comments

@Elwafi-Elmehdi
Copy link
Contributor

Hey, @chrismwilliams I hope you are doing fine, I found a small problem specifically with long post titles on the blog page, the text gets hidden after it gets wrapped up, I think the problem is the content box not dynamically changing its height, but sadly I could not submit a PR because I am a noob when it comes to Tailwind.

@chrismwilliams
Copy link
Owner

Hi @Elwafi-Elmehdi, that's cool.

I'm not quite sure if I've got where this is happening but does this look like the issue you're having.

github_issue

If it is I've got a line clamp on the title, but I can easily remove it

@Elwafi-Elmehdi
Copy link
Contributor Author

It happens on mobile devices

@chrismwilliams
Copy link
Owner

Ah, you mean this

github_issue

@Elwafi-Elmehdi
Copy link
Contributor Author

Yeah what do u think

@chrismwilliams
Copy link
Owner

Okay cool, yep that's doesn't look right and I'm not sure the line clamp is necessary either. I'll push an update soon and give you a heads up.

@Elwafi-Elmehdi
Copy link
Contributor Author

Okey thank you @chrismwilliams

@chrismwilliams
Copy link
Owner

Hey @Elwafi-Elmehdi, I've just pushed #44 to fix this. Let me know how you get on and I'll get it merged

@Elwafi-Elmehdi
Copy link
Contributor Author

He

y @chrismwilliams, Good job, the problem is solved, I am not sure how to integrate your changes to my template, another feature I think would be good is to add spacing between posts. to give the eye the ease to differentiate between posts and their descriptions.

something like this
WhatsApp Image 2023-01-30 at 11 42 37 PM

@chrismwilliams
Copy link
Owner

Hi @Elwafi-Elmehdi, I'm glad it fixed it.

I think it depends on how you created your repo, there are some guides on github, but SO has some if it was from a template this should help, or from a fork this should get you there.

With the spacing, yeah I've been changing that over the updates so I might add some more on the next one.

Thanks again @Elwafi-Elmehdi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants