Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix systemd fact usage #338

Open
treydock opened this issue Jan 7, 2025 · 0 comments · May be fixed by #339 or #340
Open

Fix systemd fact usage #338

treydock opened this issue Jan 7, 2025 · 0 comments · May be fixed by #339 or #340

Comments

@treydock
Copy link
Contributor

treydock commented Jan 7, 2025

The systemd fact conditional added in 0.14.6 is incorrect. The fact is a boolean:

https://github.com/voxpupuli/puppet-systemd/blob/58f0075f6926e3efec647f1f4d525e9ed1ad006a/lib/facter/systemd.rb#L41

So it needs to check == true not == 'systemd'.
treydock added a commit to treydock/puppet-mcollective that referenced this issue Jan 7, 2025
@treydock
(choria-io#338) Fix systemd fact usage
161e220 
The systemd fact is a boolean not a string so check if systemd == true.

Fixes choria-io#338
@treydock treydock linked a pull request Jan 7, 2025 that will close this issue
Open
@smortex smortex linked a pull request Jan 7, 2025 that will close this issue
Fix facts refreshing when refresh_type=systemd #340
Open
smortex added a commit that referenced this issue Jan 7, 2025
@smortex
(#338) Fix facts refreshing when refresh_type=systemd
db9869c 
@treydock reported that an invalid condition was introduced in #335.
This commit fix that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@treydock