Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Certificate verification #62

Closed
cmoulliard opened this issue Mar 2, 2023 · 5 comments
Closed

Disabling Certificate verification #62

cmoulliard opened this issue Mar 2, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@cmoulliard
Copy link

cmoulliard commented Mar 2, 2023

Issue

Is it possible to disable the Certificate verification with the client as I got this error ?

gosmee client https://smee.io/upi-0.apps.mystone.lab.upshift.rdu2.redhat.com https://pipelines-as-code-controller-pipelines-as-code.apps.mystone.lab.upshift.rdu2.redhat.com/
⇉ Starting gosmee version: 0.14.2
✓ Forwarding https://smee.io/upi-0.apps.mystone.lab.upshift.rdu2.redhat.com to https://pipelines-as-code-controller-pipelines-as-code.apps.mystone.lab.upshift.rdu2.redhat.com/
ERROR Forwarding Post "https://pipelines-as-code-controller-pipelines-as-code.apps.mystone.lab.upshift.rdu2.redhat.com/": x509: “ingress-operator@1676649058” certificate is not trusted

Note: Such a problem also exists if we run gosmee as a pod on k8s

@chmouel chmouel added the bug Something isn't working label Mar 2, 2023
@cmoulliard
Copy link
Author

cmoulliard commented Mar 2, 2023

We need an option like this: minio/minio-go#1019 (comment)
or simply something like

client := http.Client{Transport: &http.Transport{TLSClientConfig: &tls.Config{InsecureSkipVerify: true}}}

WDYT ? @chmouel

@chmouel
Copy link
Owner

chmouel commented Mar 2, 2023

yeah that's correct, be it optional by adding a switch!

@chmouel chmouel closed this as completed in b8ab38d Mar 2, 2023
@chmouel
Copy link
Owner

chmouel commented Mar 2, 2023

implemented in main, feel free to test it....

flag is --insecure-skip-tls-verify

@cmoulliard
Copy link
Author

cmoulliard commented Mar 3, 2023

implemented in main, feel free to test it....

Is it documented ?
Have you pushed a new image ?

@chmouel
Copy link
Owner

chmouel commented Mar 3, 2023

yes with --help and yes the docker image is generated on every push... feel free to just send a PR to update README documentation if you like..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants