-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android][1.9.0] Last value sent twice since onValueChangedStream => onValueReceived #419
Comments
can you clarify what you mean? do you have logs? |
On the device I know I have 11 values. In the first case when I trigger read() I have 11 logs, one for each value. In the second case I have 12 logs, the last one is printed twice. |
I think this is expected because you are calling When you call Are you using Android or iOS? |
This is how it has always worked on IOS. But you are right android used to work differently. I should have noticed this and put it in the ChangeLog as a breaking change. The problem is iOS does not differentiate between manual reads and notification reads. They are all the same -- we cannot tell them apart. On android manual reads and notification reads are separate callbacks. In the recent changes, android now behaves the same way as iOS. i.e. read() causes another value to appear on onValueReceived. The goal is to make both platforms behave the same way -- so we have no choice but to make Android not differentiate either. |
Ok thanks for the explanation. I think it's a good idea to make both platforms work the same way. |
Since the change onValueChangedStream => onValueReceived it seems the last value is sent twice. Do I have something else to change ?
Before :
After :
The text was updated successfully, but these errors were encountered: