From dbfd10dccea42745d5367e0a0ebaeb1c1cb46bb4 Mon Sep 17 00:00:00 2001 From: Dobios Date: Mon, 1 Jul 2024 17:51:31 -0700 Subject: [PATCH 1/2] deprecated disable intrinsic --- build.sbt | 3 ++- src/main/scala/chisel3/ltl/LTL.scala | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/build.sbt b/build.sbt index dde26a59c83..89c7c33d0cd 100644 --- a/build.sbt +++ b/build.sbt @@ -67,7 +67,8 @@ lazy val warningSuppression = Seq( // This is deprecated for external users but not internal use "cat=deprecation&origin=firrtl\\.options\\.internal\\.WriteableCircuitAnnotation:s", "cat=deprecation&origin=chisel3\\.util\\.experimental\\.BoringUtils.*:s", - "cat=deprecation&origin=chisel3\\.experimental\\.IntrinsicModule:s" + "cat=deprecation&origin=chisel3\\.experimental\\.IntrinsicModule:s", + "cat=deprecation&origin=chisel3\\.ltl.*:s" ).mkString(",") ) diff --git a/src/main/scala/chisel3/ltl/LTL.scala b/src/main/scala/chisel3/ltl/LTL.scala index 6bfebec0306..28c8ac30a42 100644 --- a/src/main/scala/chisel3/ltl/LTL.scala +++ b/src/main/scala/chisel3/ltl/LTL.scala @@ -304,6 +304,7 @@ sealed trait Property { def clock(clock: Clock)(implicit sourceInfo: SourceInfo): Property = Property.clock(this, clock) /** See `Property.disable`. */ + @deprecated def disable(cond: Disable)(implicit sourceInfo: SourceInfo): Property = Property.disable(this, cond) } @@ -394,6 +395,7 @@ object Property { * condition is true at any time during the evaluation of the property, the * evaluation is aborted. Equivalent to `disable iff (cond) prop` in SVA. */ + @deprecated def disable(prop: Property, cond: Disable)(implicit sourceInfo: SourceInfo): Property = OpaqueProperty(LTLDisableIntrinsic(prop.inner, cond.value)) } From d6984f60d66109905a4f1e6ff84d4568092b1b2b Mon Sep 17 00:00:00 2001 From: Jack Koenig Date: Mon, 1 Jul 2024 17:55:39 -0700 Subject: [PATCH 2/2] Apply suggestions from code review --- src/main/scala/chisel3/ltl/LTL.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/scala/chisel3/ltl/LTL.scala b/src/main/scala/chisel3/ltl/LTL.scala index 28c8ac30a42..1193578634f 100644 --- a/src/main/scala/chisel3/ltl/LTL.scala +++ b/src/main/scala/chisel3/ltl/LTL.scala @@ -304,7 +304,7 @@ sealed trait Property { def clock(clock: Clock)(implicit sourceInfo: SourceInfo): Property = Property.clock(this, clock) /** See `Property.disable`. */ - @deprecated + @deprecated("Use withDisable", "Chisel 6.5") def disable(cond: Disable)(implicit sourceInfo: SourceInfo): Property = Property.disable(this, cond) } @@ -395,7 +395,7 @@ object Property { * condition is true at any time during the evaluation of the property, the * evaluation is aborted. Equivalent to `disable iff (cond) prop` in SVA. */ - @deprecated + @deprecated("Use withDisable", "Chisel 6.5") def disable(prop: Property, cond: Disable)(implicit sourceInfo: SourceInfo): Property = OpaqueProperty(LTLDisableIntrinsic(prop.inner, cond.value)) }