Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source_removal): handle csd of sidereal stacks properly #26

Merged
merged 2 commits into from
Dec 13, 2019

Conversation

ssiegelx
Copy link
Contributor

Previously we had assumed that the csd attribute is a scalar, but in
the case of sidereal stacks it is a list.

Previously we had assumed that the csd attribute is a scalar, but in
the case of sidereal stacks it is a list.
@ssiegelx ssiegelx requested review from cahofer and pboubel December 13, 2019 16:50
pboubel
pboubel previously approved these changes Dec 13, 2019
This was missed in previous commit.
Copy link
Contributor

@cahofer cahofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we checked it running the pipeline and it works! thanks!

@ssiegelx ssiegelx merged commit 4d38d4e into master Dec 13, 2019
@ssiegelx ssiegelx deleted the ss/source_removal_fix branch December 13, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants