This repository has been archived by the owner on Aug 27, 2024. It is now read-only.
feat(demo-app): update meta data for site #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still need to implement `PageMetaDataService.updateMeta` and figure out why `spyOn` not working in tests
peterjokumsen
added
documentation ✍️
|
[ng-libs | Demo App] Kudos, SonarCloud Quality Gate passed! |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-flower-0950bd703-60.westeurope.2.azurestaticapps.net |
lgpage
approved these changes
Jan 6, 2023
This was referenced Jan 6, 2023
Closed
This was referenced Jan 14, 2023
Merged
peterjokumsen
added a commit
that referenced
this pull request
Feb 27, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>ng-libs: 2.1.0</summary> ## [2.1.0](ng-libs-v2.0.0...ng-libs-v2.1.0) (2023-02-27) ### Features * **demo-app:** add navigation ([#76](#76)) ([bfc9cb5](bfc9cb5)) * **demo-app:** add packages page ([#68](#68)) ([233177b](233177b)) * **demo-app:** update meta data for site ([#60](#60)) ([c9132b5](c9132b5)) ### Bug Fixes * **config:** update release config ([bd2a00d](bd2a00d)) * **deps:** update angular monorepo to ~15.1.0 ([addf4fd](addf4fd)) * **deps:** update angular monorepo to ~15.2.0 ([#114](#114)) ([2823441](2823441)) * **deps:** update nrwl monorepo to v15.4.5 ([85ac337](85ac337)) * **deps:** update nrwl monorepo to v15.6.3 ([5cfe534](5cfe534)) * **deps:** update nrwl monorepo to v15.7.2 ([#104](#104)) ([9b06861](9b06861)) * **layout:** update package metadata ([#70](#70)) ([757061e](757061e)) </details> <details><summary>layout: 2.0.1</summary> ## [2.0.1](layout-v2.0.0...layout-v2.0.1) (2023-02-27) ### Bug Fixes * **deps:** update angular monorepo to ~15.1.0 ([addf4fd](addf4fd)) * **deps:** update angular monorepo to ~15.2.0 ([#114](#114)) ([2823441](2823441)) * **layout:** update package metadata ([#70](#70)) ([757061e](757061e)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: chill-viking Release <124516721+release-chill-viking@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Description
Update to set meta tags for page when title set. Will consume meta tags from route
data.metaTagsif set for the current primary navigation.Fixes #44
🚀 Type of change
🧪 How Has This Been Tested?
🧾 Checklist: