This repository has been archived by the owner on Aug 27, 2024. It is now read-only.
add service for layout context #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-flower-0950bd703-116.westeurope.2.azurestaticapps.net |
To be used to provide context, to override context for layout when not provided.
peterjokumsen
force-pushed
the
feat/add-service-for-layout-context-46
branch
from
cb2fb1a to
8bb4868
Compare
|
[ng-libs | cv-layout] Kudos, SonarCloud Quality Gate passed! |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-flower-0950bd703-116.westeurope.2.azurestaticapps.net |
|
[ng-libs | Demo App] Kudos, SonarCloud Quality Gate passed! |
release-chill-viking
approved these changes
Feb 27, 2023
peterjokumsen
added a commit
that referenced
this pull request
Feb 27, 2023
## 🎉 Description Added service to allow for defining and updating layout context. Fixes #46 ## 🚀 Type of change - [x] 🆕 New feature (non-breaking change which adds functionality) ## 🧪 How Has This Been Tested? - [x] Demo-app updated to use new functionality and served locally - [x] New specs created to confirm functionality works as intended ## 🧾 Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules BEGIN_COMMIT_OVERRIDE chore(deps): remove decorate-angular postInstall feat(layout): create layout-context service To be used to provide context, to override context for layout when not provided. feat(layout): use layout-context service for layout data feat(layout): add static function to provide services feat(demo-app): use layout-context service for context chore(docs): update README to include latest update END_COMMIT_OVERRIDE
peterjokumsen
added a commit
that referenced
this pull request
Feb 27, 2023
## 🎉 Description Added service to allow for defining and updating layout context. Fixes #46 ## 🚀 Type of change - [x] 🆕 New feature (non-breaking change which adds functionality) ## 🧪 How Has This Been Tested? - [x] Demo-app updated to use new functionality and served locally - [x] New specs created to confirm functionality works as intended ## 🧾 Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules chore(deps): remove decorate-angular postInstall feat(layout): create layout-context service To be used to provide context, to override context for layout when not provided. feat(layout): use layout-context service for layout data feat(layout): add static function to provide services feat(demo-app): use layout-context service for context chore(docs): update README to include latest update
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Description
Added service to allow for defining and updating layout context.
Fixes #46
🚀 Type of change
🧪 How Has This Been Tested?
🧾 Checklist: