Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve unit test coverage #120

Open
razumau opened this issue Jul 14, 2024 · 0 comments
Open

improve unit test coverage #120

razumau opened this issue Jul 14, 2024 · 0 comments
Assignees

Comments

@razumau
Copy link
Contributor

razumau commented Jul 14, 2024

We more or less properly test only two recent additions (roster continuity rules and missing rosters adjustments). There are some unit tests for utility functions in test_tools, but not even all those functions are covered.

We have end-to-end tests (calculate a release, verify that numbers haven’t changed), but they cannot cover all potential data issues. We can expand those tests as well, but it’s not feasible to calculate more than two or three releases in general CI runs (this would take too long).

Some functions probably need refactoring to make them testable.

@AlexKaryasov AlexKaryasov self-assigned this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants