Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diff matching #14

Closed
xlc opened this issue Jul 28, 2021 · 2 comments
Closed

Improve diff matching #14

xlc opened this issue Jul 28, 2021 · 2 comments
Labels
diff Related to diff-ing runtimes

Comments

@xlc
Copy link
Contributor

xlc commented Jul 28, 2021 •
edited
Loading

It should match against with the real module index, not sequence order.

e.g. This diff is indicating a very big change but it is caused by comparing wrong modules.
AcalaNetwork/Acala#1256 (comment)

🛠  modules.21.index.                                                    50 --> 45
🛠  modules.21.name.                                            "XcmpQueue" --> "SessionManager"

This just means it is comparing the wrong thing.
@chevdor
Copy link
Owner

chevdor commented Jul 29, 2021

👍 I noticed that as well. Thanks for the report.

@chevdor chevdor mentioned this issue Aug 16, 2021
Closed
@chevdor chevdor added the diff Related to diff-ing runtimes label Jul 6, 2022
@chevdor
Copy link
Owner

chevdor commented Jun 23, 2023

Closing this issue now as the version 0.20.0 is doing a much better job. Check both the diff and the new show commands.

@chevdor chevdor closed this as completed Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
diff Related to diff-ing runtimes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chevdor @xlc