From 0504351b628806d6dba36f7c3615797e9ca7e70a Mon Sep 17 00:00:00 2001 From: mciolek Date: Sun, 25 Jun 2017 22:15:01 +0200 Subject: [PATCH 1/3] Allowing offsets.topic.retention.minutes to be configured --- config/server.properties.template | 1 + start.sh | 1 + 2 files changed, 2 insertions(+) diff --git a/config/server.properties.template b/config/server.properties.template index 154cc60..2350c2e 100644 --- a/config/server.properties.template +++ b/config/server.properties.template @@ -74,5 +74,6 @@ controlled.shutdown.enable=true group.max.session.timeout.ms={{KAFKA_GROUP_MAX_SESSION_TIMEOUT_MS}} inter.broker.protocol.version={{KAFKA_INTER_BROKER_PROTOCOL_VERSION}} log.message.format.version={{KAFKA_LOG_MESSAGE_FORMAT_VERSION}} +offsets.retention.minutes={{KAFKA_OFFSETS_RETENTION_MINUTES}} # vim:set filetype=jproperties diff --git a/start.sh b/start.sh index 947b138..0051ac8 100755 --- a/start.sh +++ b/start.sh @@ -22,6 +22,7 @@ cat /kafka/config/server.properties.template | sed \ -e "s|{{KAFKA_INTER_BROKER_PROTOCOL_VERSION}}|${KAFKA_INTER_BROKER_PROTOCOL_VERSION:-$KAFKA_VERSION}|g" \ -e "s|{{KAFKA_LOG_MESSAGE_FORMAT_VERSION}}|${KAFKA_LOG_MESSAGE_FORMAT_VERSION:-$KAFKA_VERSION}|g" \ -e "s|{{KAFKA_LOG_RETENTION_HOURS}}|${KAFKA_LOG_RETENTION_HOURS:-168}|g" \ + -e "s|{{KAFKA_OFFSETS_RETENTION_MINUTES}}|${KAFKA_OFFSETS_RETENTION_MINUTES:-10080}|g" \ -e "s|{{KAFKA_NUM_PARTITIONS}}|${KAFKA_NUM_PARTITIONS:-1}|g" \ -e "s|{{KAFKA_PORT}}|${KAFKA_PORT:-9092}|g" \ -e "s|{{ZOOKEEPER_CHROOT}}|${ZOOKEEPER_CHROOT:-}|g" \ From 4f9cc430cf5bc4f8a3ed081155a70b054d2224a8 Mon Sep 17 00:00:00 2001 From: mciolek Date: Sun, 25 Jun 2017 22:16:05 +0200 Subject: [PATCH 2/3] Fixing default value --- start.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/start.sh b/start.sh index 0051ac8..46cb6a7 100755 --- a/start.sh +++ b/start.sh @@ -22,7 +22,7 @@ cat /kafka/config/server.properties.template | sed \ -e "s|{{KAFKA_INTER_BROKER_PROTOCOL_VERSION}}|${KAFKA_INTER_BROKER_PROTOCOL_VERSION:-$KAFKA_VERSION}|g" \ -e "s|{{KAFKA_LOG_MESSAGE_FORMAT_VERSION}}|${KAFKA_LOG_MESSAGE_FORMAT_VERSION:-$KAFKA_VERSION}|g" \ -e "s|{{KAFKA_LOG_RETENTION_HOURS}}|${KAFKA_LOG_RETENTION_HOURS:-168}|g" \ - -e "s|{{KAFKA_OFFSETS_RETENTION_MINUTES}}|${KAFKA_OFFSETS_RETENTION_MINUTES:-10080}|g" \ + -e "s|{{KAFKA_OFFSETS_RETENTION_MINUTES}}|${KAFKA_OFFSETS_RETENTION_MINUTES:-1440}|g" \ -e "s|{{KAFKA_NUM_PARTITIONS}}|${KAFKA_NUM_PARTITIONS:-1}|g" \ -e "s|{{KAFKA_PORT}}|${KAFKA_PORT:-9092}|g" \ -e "s|{{ZOOKEEPER_CHROOT}}|${ZOOKEEPER_CHROOT:-}|g" \ From db75bd8e2231433d93057abeec3efb18e3a99adf Mon Sep 17 00:00:00 2001 From: mciolek Date: Sun, 25 Jun 2017 22:35:52 +0200 Subject: [PATCH 3/3] Updating README --- README.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/README.md b/README.md index 2540cd7..77cbf0c 100644 --- a/README.md +++ b/README.md @@ -129,6 +129,7 @@ with their default values, if any: Maps to Kafka's `num.partitions` setting. The default number of log partitions per topic. + - `KAFKA_AUTO_CREATE_TOPICS_ENABLE=true` Maps to Kafka's `auto.create.topics.enable`. @@ -145,6 +146,10 @@ with their default values, if any: Maps to Kafka's `log.retention.hours`. The number of hours to keep a log file before deleting it. +- `KAFKA_OFFSETS_RETENTION_MINUTES=1440` + + Maps to Kafka's `offsets.retention.minutes`. The number of minutes to keep + an offset for a consumer group before deleting it. - `JAVA_RMI_SERVER_HOSTNAME=$KAFKA_ADVERTISED_HOST_NAME` Maps to the `java.rmi.server.hostname` JVM property, which is used to bind the