Skip to content
This repository has been archived by the owner on Nov 13, 2022. It is now read-only.

Missing images in asset.json #77

Closed
chenxsan opened this issue Jun 6, 2020 · 6 comments · Fixed by #83
Closed

Missing images in asset.json #77

chenxsan opened this issue Jun 6, 2020 · 6 comments · Fixed by #83

Comments

@chenxsan
Copy link
Owner

chenxsan commented Jun 6, 2020 •
edited
Loading

After replacing the plugin with webpack-manifest-plugin, we have a new problem now.
@chenxsan
Copy link
Owner Author

chenxsan commented Jun 7, 2020

It's because webpack outputs the asset name with contenthash in toJson() method.

@chenxsan
Copy link
Owner Author

chenxsan commented Jun 8, 2020 •
edited
Loading

From what I see in facebook/create-react-app#5225, it's how it works.

@chenxsan chenxsan linked a pull request Jun 8, 2020 that will close this issue
Bugfix/fix assets json #83
Merged
@chenxsan chenxsan closed this as completed Jun 8, 2020
@chenxsan chenxsan reopened this Jun 24, 2020
@chenxsan
Copy link
Owner Author

It's difficult to use those output html pages in server side languages like php etc. because asset.json contains hash in keys.

@chenxsan
Copy link
Owner Author

Might be related shellscape/webpack-manifest-plugin#209

@chenxsan chenxsan pinned this issue Jun 25, 2020
@chenxsan
Copy link
Owner Author

chenxsan commented Jun 26, 2020 •
edited
Loading

It's a problem of asset modules not handled by the plugin. It did support file-loader for images.

@chenxsan
Copy link
Owner Author

It might be better to support it in webpack core.

@chenxsan chenxsan unpinned this issue Jun 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/fix assets json chenxsan/voidjs
1 participant
@chenxsan