Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean_redeem never uses fdr argument #15

Open
mfansler opened this issue Sep 2, 2024 · 0 comments
Open

clean_redeem never uses fdr argument #15

mfansler opened this issue Sep 2, 2024 · 0 comments

Comments

@mfansler
Copy link

mfansler commented Sep 2, 2024

The clean_redeem function hardcodes an FDR of 5%:

redeemR/R/BuidTree.R

Lines 951 to 952 in c9de785

clean_redeem <-function(ob,fdr=0.05){
ob@V.fitered <- subset(ob@V.fitered,qvalues<=0.05)

@mfansler mfansler changed the title clean_redeem never uses argument clean_redeem never uses fdr argument Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant