Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update NNlib and Flux compat #153

Closed
CarloLucibello opened this issue Sep 20, 2023 · 9 comments
Closed

update NNlib and Flux compat #153

CarloLucibello opened this issue Sep 20, 2023 · 9 comments

Comments

@CarloLucibello
Copy link

This package is incompatible with Flux 0.14 and NNlib 0.9. Can the compatibility be updated?

@chengchingwen
Copy link
Owner

What are the breaking changes beside dropping julia 1.6 and using package extension?

@CarloLucibello
Copy link
Author

Just the extension thing. So NNlibCUDA is deprecated, and for CUDA support in Flux one has to explicitly load CUDA.jl

@CarloLucibello
Copy link
Author

I think the only required change here is to drop NNlibCUDA and to increase julia compatibility to >= 1.9.

@chengchingwen
Copy link
Owner

Yes, but I'm a little worried about dropping julia < 1.9.

@CarloLucibello
Copy link
Author

Julia 1.9 changed many things. I'm sure those interested in getting package updates are already using it.
On the other hand, it seems more problematic not to get Flux and NNlib updates if you have this package in your environment.

@originalsouth
Copy link
Contributor

Yes, but I'm a little worried about dropping julia < 1.9.

@chengchingwen can you please elaborate?

@chengchingwen
Copy link
Owner

@originalsouth Simply because julia 1.6 is the LTS version.

@originalsouth
Copy link
Contributor

I guess most FluxML packages as Flux.jl has dropped that support already... perhaps an LTS branch for this repository can mediate the conflict of interests?

@johannes-fischer
Copy link

6 months later, any updates on updating Flux compat? I think this is long overdue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants