Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to update compat #22

Closed
wants to merge 2 commits into from
Closed

Conversation

pat-alt
Copy link

@pat-alt pat-alt commented Jan 13, 2024

  • Removing to::CUDA.Adaptor everywhere and no longer typing this at all. CUDA.Adaptor seems to be deprecated but I can't find anything about it in docs.
  • Removing NNlibCUDA since this seems to now by handled through an extension.

@chengchingwen
Copy link
Owner

  1. CUDA.Adaptor is renamed as CUDA.KernelAdaptor after CUDA@5.1. Generally the overloading of adapt_storage already covers all the conversions. Overloading adapt(::Adaptor, ...) is a special case for using those masks directly in cuda kernel. However, I do think this design isn't that useful, so I might change it in the future.
  2. Package extension is added after Julia v1.9. OTOH, this package tried to maintain the support of LTS version (which is v1.6 right now). I was waiting for a new LTS version and dropping v1.6 right after the new LTS release. Unfortunately, this doesn't seem to happen shortly, so we would probably need to maintain a new branch for Julia above v1.9.

@chengchingwen chengchingwen mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants