Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with prediction and expanded protons #3229

Closed
lpatiny opened this issue Sep 11, 2024 · 1 comment · Fixed by #3245
Closed

Bug with prediction and expanded protons #3229

lpatiny opened this issue Sep 11, 2024 · 1 comment · Fixed by #3245
Assignees
Labels
bug Something isn't working

Comments

@lpatiny
Copy link
Member

lpatiny commented Sep 11, 2024

If you predict ethylbenzene and check the COSY.

The hover correctly highlight the corresponding atoms (carbon).

But if you expand the hydrogens (shift + click on the atom) the highlight does not work anymore, even if you collapse again.

2024-09-11 10 12 56

@hamed-musallam Could you have a look at this bug. It could be on my side in react-ocl-nmr

@lpatiny lpatiny added the bug Something isn't working label Sep 11, 2024
@hamed-musallam
Copy link
Member

hamed-musallam commented Sep 13, 2024

@lpatiny
it appears that due to changes in the rendering and positioning of the molecule structure in the OLCnmr component, the setHoverAtom function is no longer being triggered (The event is not yet attached when the mouse moves away from the atom), which causes the hover effect on 2D signals to persist. As a temporary workaround, we can call the function responsible for handling the mouse leave action when Shift + Click is used to resolve this issue.

@lpatiny lpatiny changed the title But with prediction and expanded protons Bug with prediction and expanded protons Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
2 participants