Fedora 41 build fails during cleanup

[b00ga]

bento/packer_templates/scripts/fedora/cleanup_dnf.sh

Line 28 in 74602d4

find /etc/sysconfig/network-scripts -name "ifcfg-*" -not -name "ifcfg-lo" -exec rm -f {} \;

Above referenced find command fails (No such file or directory) and build stops with failed exit status.

Did some digging. ifcfg files (in the /etc/sysconfig/network-scripts directory) have been deprecated since Fedora 36 in favor of NetworkManager keyfiles (aka ini files) [1]. However ifcfg files would still work.

In Fedora 41, the network-scripts package (which provides the ifcfg files and their support) was completely removed from Fedora 41 [2]. Due to this removal, we no longer get an /etc/sysconfig/network-scripts directory, and so this cleanup failure.

This change needs to be accounted for in Fedora's cleanup script.

[1] https://fedoramagazine.org/converting-networkmanager-from-ifcfg-to-keyfiles/
[2] https://fedoraproject.org/wiki/Releases/41/ChangeSet#Removing_network-scripts_package

[b00ga]

Just thinking "out loud". A quick first-pass fix may be to just check for the existence of the directory (aka wrap this find in an if [ -d /etc/sysconfig/network-scripts]; then ; fi)

[skyscooby]

Just thinking "out loud". A quick first-pass fix may be to just check for the existence of the directory (aka wrap this find in an if [ -d /etc/sysconfig/network-scripts]; then ; fi)

That would get rid of the error.. but does the functionality also need to be translated to the NetworkManager replacement? (ie remove all ini files except localhosts?)... or is NetworkManager sufficiently dynamic? I guess it depends on why this was added to the cleanup scripts in the first place.. I'm guessing due to dynamic nature of interface names on different providers.

[Stromweld]

This was all created way before my time, and has probably been a hold over. Not much changes till it breaks on newer versions then gets updated. Thanks for the suggestion I'm implementing that now to fix it in #1596